Skip to content

feat(cli): submit keyless job feedback - #221

Draft
Max17190 wants to merge 8 commits into
mainfrom
max/enable-keyless-feedback
Draft

feat(cli): submit keyless job feedback#221
Max17190 wants to merge 8 commits into
mainfrom
max/enable-keyless-feedback

Conversation

@Max17190

@Max17190 Max17190 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Why

Keyless CLI callers need to submit structured evidence for Search, Scrape, and Parse while preserving ordinary command output.

Summary

  • Define Search source as the response group containing the observed position. Use stored category tags for serving attribution; callers do not submit engine attribution.
  • Allow firecrawl feedback without an API key and add task, assessment, observation JSON/file options, and Parse --doc-class for the shared endpoint. Preserve authenticated feedback options. Resolve explicit feedback API URLs directly so keyless submissions do not invoke the SDK credential validator.
  • Preserve job references and invitation metadata, including execution failures. Write optional guidance to stderr and retain metadata in JSON output.
  • Retain server-issued keyless invitations and allow optional keyless submissions regardless of local feedback flags. Preserve existing authenticated feedback opt-outs and the authenticated Search feedback command. Scope new operation guidance to keyless jobs.
  • Explain category-specific kinds, reason enums, Search verticals, requested source/format attribution, and one accepted submission per identity per UTC day across all three categories and clients in help, README, and bundled Search skills. Keep feedback optional and outside search completion requirements.

Depends on firecrawl/firecrawl#4616. Configure and deploy the API feedback support before releasing these client changes.

Test Plan

  • Passed: 90 targeted command and output tests in a credential-free test environment covering feedback, Search, Scrape, Parse, invitations, and authenticated feedback preferences.
  • Verified keyless requests omit Authorization, keyless operations omit invitation opt-out headers, submissions remain available with local feedback flags enabled, and stdout remains unchanged by invitations.
  • Verified Parse document-class validation and transport, retained structured reason/format/page fields, and Parse invitation commands including --doc-class.
  • Passed: pnpm run build, formatting of changed TypeScript files, and git diff --check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant